fix(text): avoid trailing None for paginated response + scalar --query#10087
Closed
mjfxjas wants to merge 2 commits intoaws:developfrom
Closed
fix(text): avoid trailing None for paginated response + scalar --query#10087mjfxjas wants to merge 2 commits intoaws:developfrom
mjfxjas wants to merge 2 commits intoaws:developfrom
Conversation
Author
|
Friendly follow-up on this behavior fix. This addresses trailing None output when using paginated responses with scalar --query, and keeps output consistent and clean for scripting use cases. If useful, I can add an additional regression test case in the preferred location. |
Contributor
|
Hi @mjfxjas, thanks for this pull request. We've received many issues in the past about the interaction between |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10061.
When an operation is paginated, the text formatter previously applied
--queryper page. For scalar queries, if subsequent pages did not include the queried field, text output could include an extra trailingNoneline.This change buffers the full paginated result before applying
--querywhen using--output text, matching the behavior of the JSON/table formatters.